Open
Conversation
WalkthroughRegistry entries moved from one raw.githubusercontent base path to a new commit-based base path in Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
0xgleb
approved these changes
Mar 16, 2026
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/auction-dca.rain`:
- Around line 565-566: Update the user-facing preset label string "name: 8 hour
(28800)" to correct grammar by changing it to "name: 8 hours (28800)" and make
the same change for the duplicate preset occurrence later in the file (the other
"name: 8 hour (28800)" instance); ensure only the label text is changed and the
corresponding "value: 28800" remains unchanged so behavior is not affected.
- Around line 554-560: The default for the configuration key
oracle-price-timeout was reduced to 300 (5 minutes), which is a breaking change;
revert this default back to the prior/legacy value used before this change
(restore the former numeric default), apply the same revert to the other
occurrence of oracle-price-timeout, and ensure any related presets/docs/tests
are updated to reflect the restored default so deployments keep the original
staleness tolerance by default.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: a3d7d532-6f30-4a6a-a1a8-0b4d1c832ef0
📒 Files selected for processing (2)
registrysrc/auction-dca.rain
Comment on lines
+554
to
+560
| - binding: oracle-price-timeout | ||
| name: Oracle Price Timeout | ||
| description: | | ||
| How fresh (recent) the price is. | ||
| show-custom-field: true | ||
| default: 300 | ||
| presets: |
There was a problem hiding this comment.
Default timeout drops from prior behavior to 5 minutes and can break expected auction execution windows.
Setting oracle-price-timeout default to 300 materially tightens staleness tolerance. If the prior behavior relied on a much longer timeout, this is a breaking default change for new deployments unless users override it.
Suggested fix (preserve legacy behavior by default)
- binding: oracle-price-timeout
name: Oracle Price Timeout
description: |
How fresh (recent) the price is.
show-custom-field: true
- default: 300
+ default: 86400
presets:
- name: 5 minutes (300)
value: 300
- name: 1 hour (3600)
value: 3600
- name: 8 hour (28800)
value: 28800
+ - name: 24 hours (86400)
+ value: 86400
- name: 3 days (259200)
value: 259200Also applies to: 727-733
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/auction-dca.rain` around lines 554 - 560, The default for the
configuration key oracle-price-timeout was reduced to 300 (5 minutes), which is
a breaking change; revert this default back to the prior/legacy value used
before this change (restore the former numeric default), apply the same revert
to the other occurrence of oracle-price-timeout, and ensure any related
presets/docs/tests are updated to reflect the restored default so deployments
keep the original staleness tolerance by default.
Comment on lines
+565
to
+566
| - name: 8 hour (28800) | ||
| value: 28800 |
There was a problem hiding this comment.
Fix preset label grammar (8 hour → 8 hours).
This is user-facing text in both deployment forms.
Suggested fix
- - name: 8 hour (28800)
+ - name: 8 hours (28800)
value: 28800Also applies to: 738-739
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/auction-dca.rain` around lines 565 - 566, Update the user-facing preset
label string "name: 8 hour (28800)" to correct grammar by changing it to "name:
8 hours (28800)" and make the same change for the duplicate preset occurrence
later in the file (the other "name: 8 hour (28800)" instance); ensure only the
label text is changed and the corresponding "value: 28800" remains unchanged so
behavior is not affected.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@registry`:
- Around line 1-9: The registry currently pins resources to commit
46b9e1e34aac97555831f0f466ef548d3a599987 which isn't on main yet; revert the
commit-specific URLs in the registry (the lines referencing settings.yaml and
the strategy .rain URLs) to either unpinned/main branch URLs or remove the pins,
and leave a TODO comment to update these URLs to the final main commit hash
after this PR is merged so the registry only references commit hashes that exist
on main.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: fb13416b-544e-4e84-987c-e913185dd451
📒 Files selected for processing (2)
registrysrc/auction-dca.rain
Comment on lines
+1
to
+9
| https://raw.githubusercontent.com/rainlanguage/rain.strategies/46b9e1e34aac97555831f0f466ef548d3a599987/settings.yaml | ||
| fixed-limit https://raw.githubusercontent.com/rainlanguage/rain.strategies/46b9e1e34aac97555831f0f466ef548d3a599987/src/fixed-limit.rain | ||
| auction-dca https://raw.githubusercontent.com/rainlanguage/rain.strategies/46b9e1e34aac97555831f0f466ef548d3a599987/src/auction-dca.rain | ||
| grid https://raw.githubusercontent.com/rainlanguage/rain.strategies/46b9e1e34aac97555831f0f466ef548d3a599987/src/grid.rain | ||
| dynamic-spread https://raw.githubusercontent.com/rainlanguage/rain.strategies/46b9e1e34aac97555831f0f466ef548d3a599987/src/dynamic-spread.rain | ||
| canary https://raw.githubusercontent.com/rainlanguage/rain.strategies/46b9e1e34aac97555831f0f466ef548d3a599987/src/canary.rain | ||
| claims https://raw.githubusercontent.com/rainlanguage/rain.strategies/46b9e1e34aac97555831f0f466ef548d3a599987/src/claims.rain | ||
| fixed-spread https://raw.githubusercontent.com/rainlanguage/rain.strategies/46b9e1e34aac97555831f0f466ef548d3a599987/src/fixed-spread.rain | ||
| folio https://raw.githubusercontent.com/rainlanguage/rain.strategies/46b9e1e34aac97555831f0f466ef548d3a599987/src/folio.rain |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify if the commit hash exists on main branch
git fetch origin main
git branch --contains 46b9e1e34aac97555831f0f466ef548d3a599987 | grep -E '^\*?\s*main$' || echo "Commit not found on main branch"Repository: rainlanguage/rain.strategies
Length of output: 219
Update registry after merging to main.
The commit hash 46b9e1e34aac97555831f0f466ef548d3a599987 does not exist on the main branch yet. Registry URLs must be pinned only after changes are merged to main, per coding guidelines. Update the registry file once this PR is merged and the commit is available on main.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@registry` around lines 1 - 9, The registry currently pins resources to commit
46b9e1e34aac97555831f0f466ef548d3a599987 which isn't on main yet; revert the
commit-specific URLs in the registry (the lines referencing settings.yaml and
the strategy .rain URLs) to either unpinned/main branch URLs or remove the pins,
and leave a TODO comment to update these URLs to the final main commit hash
after this PR is merged so the registry only references commit hashes that exist
on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Update auction
Checks
By submitting this for review, I'm confirming I've done the following:
Summary by CodeRabbit
New Features
Chores