Exclude Fleet config files regardless of their naming

[weyfonk]

While Fleet config files are typically named fleet.yaml, the recent introduction of user-driven bundle scanning enables a config file to be named arbitrarily, in which case it must still be excluded from the corresponding bundle. Fleet now takes care of this without any action needed from the user.

Integration tests also demonstrate that .fleetignore files can be leveraged to exclude config files living in the same directory as the config file referenced explicitly through user-driven bundle scanning. Fleet would otherwise not exclude those files from the bundle.

Refers to rancher/fleet-docs#307

Additional Information

Checklist

• I have updated the documentation via a pull request in the
  fleet-docs repository: see Add warning on excluding non-referenced configuration files fleet-docs#354

[p-se]

I was wondering .fleetignore is being tested separately elsewhere? Because it looks like both prod.yaml and dev.yaml are supposed to be excluded from the bundle without even having a .fleetignore. Which would mean that .fleetignore wouldn't be tested at all in that particular test. But I have found separate tests for .fleetignore elsewhere in our code.

[weyfonk]

I was wondering .fleetignore is being tested separately elsewhere?

Yes, we test its behaviour in internal/bundlereader/loaddirectory_test.go.

Because it looks like both prod.yaml and dev.yaml are supposed to be excluded from the bundle without even having a .fleetignore.

The test case using the driven/kustomize directory uses a .fleetignore excluding only dev.yaml, to check that it's then excluded from both dev and prod bundles. See this comment.

Conversely, the test case using driven2/kustomize uses a .fleetignore excluding only prod.yaml, for similar reasons (see this comment).