Skip to content

Fix Prometheus text parser instantiation in benchmarks #4269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weyfonk merged 2 commits into from
Oct 28, 2025
Merged

Fix Prometheus text parser instantiation in benchmarks #4269

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b861a33
Fix Prometheus text parser instantiation in benchmarks
weyfonk Oct 28, 2025
e8021a1
Fix linting error
weyfonk Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion benchmarks/record/record.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
gm "github.com/onsi/gomega/gmeasure"
dto "github.com/prometheus/client_model/go"
"github.com/prometheus/common/expfmt"
"github.com/prometheus/common/model"

"github.com/rancher/fleet/e2e/testenv/kubectl"
"github.com/rancher/fleet/pkg/apis/fleet.cattle.io/v1alpha1"
Expand Down Expand Up @@ -234,7 +235,7 @@
pod := addRandomSuffix("curl")
var (
mfs map[string]*dto.MetricFamily
parser expfmt.TextParser
parser expfmt.TextParser = expfmt.NewTextParser(model.LegacyValidation)

Check failure on line 238 in benchmarks/record/record.go

View workflow job for this annotation

GitHub Actions / golangci-lint 

ST1023: should omit type expfmt.TextParser from declaration; it will be inferred from the right-hand side (staticcheck)
)
Eventually(func() error {
GinkgoWriter.Print("Fetching metrics from " + url + "\n")
Expand Down
Loading