Replace community doc URLs and project names (Storage, Networking, Upgrades)#80
Conversation
Signed-off-by: Jillian <jillian.maroket@suse.com>
Signed-off-by: Jillian <jillian.maroket@suse.com>
Signed-off-by: Jillian <jillian.maroket@suse.com>
…ices file Signed-off-by: Jillian <jillian.maroket@suse.com>
Signed-off-by: Jillian <jillian.maroket@suse.com>
Signed-off-by: Jillian <jillian.maroket@suse.com>
| image::storageclass/create_storageclasses_migratable.png[] | ||
|
|
||
| === Customize Tab | ||
| **Allow Volume Expansion** |
There was a problem hiding this comment.
Is this intentional? Seems this part should be a Reclaim Policy?
There was a problem hiding this comment.
@pmkovar Thanks for reviewing and for catching that error. I don't know what caused it. This is old content that I have not touched since joining the company.
Instead of just fixing this error, I decided to restructure the section altogether to address issues that I had flagged in a previous audit. I'll apply the same changes to the community doc later on.
jhkrug
left a comment
jhkrug
left a comment
There was a problem hiding this comment.
One tiny observation.
I'm approving as the PR seems to mainly be about parameterization, which is great.
| [NOTE] | ||
| ==== | ||
| {harvester-product-name} sets the https://longhorn.io/docs/1.7.2/v2-data-engine/features/node-disk-support/[Longhorn disk driver] to `auto` so that NVMe disks use the SPDK NVMe bdev driver, which provides the best performance and also supports advanced operations such as trim (also known as discard). | ||
| {harvester-product-name} sets the https://documentation.suse.com/cloudnative/storage/1.8.0/en/longhorn-system/v2-data-engine/features/node-disk-support.html[Longhorn Disk Driver] to `auto` so that NVMe disks use the SPDK NVMe bdev driver, which provides the best performance and also supports advanced operations such as trim (also known as discard). |
There was a problem hiding this comment.
This caught my eye. This PR is mostly about parameterization, so maybe that 'Longhorn' in the []?
There was a problem hiding this comment.
@jhkrug Thanks for reviewing. I have not rebranded Longhorn components anywhere in the doc. I'll do another round of parameterization PRs once I hear back from the PM group.
Signed-off-by: Jillian <jillian.maroket@suse.com>
3 participants
Related issue: #77
Scope: v1.3, v1.4, v1.5, v1.6
networking/best-practices.adocstorage/longhorn-v2-data-engine.adocstorage/storageclass.adocstorage/volumes/edit-volume.adocstorage/longhorn-v2-data-engine.adocupgrades/troubleshooting.adocupgrades/upgrades.adocChanges: