Add missing validations for Policy create page#1478
Conversation
kravciak
left a comment
There was a problem hiding this comment.
Inputs don't reflect right value when switching to YAML Editor and back
Screencast.From.2026-04-14.14-45-51.mp4
Could you write a YAML of the generated code you expect instead? I personally preferred to reset it rather than assume it's broken, as the value is composed. |
I expect UI inputs to show real state of what is sent when I click Finish button. |
Let's do it like this, I set it back to the previous one and then you tell me how do you expect to be validated in case is not fine. |
|
So @kravciak this is how it worked before and how it reflects by validating the data instead of the inputs. Kapture.2026-04-14.at.17.12.28.mp4 |
|
I will look into it later today or tomorrow, I am jumping between things - sorry for delay |
No problem, actually thanks for the patience :D |
|
I see new #1482 with the same name which "fixes" this PR. |
|
About this PR, it looks good, but I see one issue: When I switch to Edit Yaml and back:
Would it be possible to refresh Screencast.From.2026-04-17.13-11-20.mp4 |
This is strange, I tested exactly that and is in my video. I take a look at it again to see if anything is wrong. |
It's just me messing with the links :D |
Taking a look into it. It occurs only on first edit and just that input 🤯 |
|
@kravciak now the logic seems to work fine Kapture.2026-04-24.at.10.10.54.mp4 |
Fixes #1477
Logic insight:
Kapture.2026-04-15.at.23.07.03.mp4
Kapture.2026-04-24.at.10.10.54.mp4