GCE node driver improvements#345
Merged
Merged
Conversation
b293317 to
86867cf
Compare
86867cf to
2bcbafb
Compare
jakefhyde
requested changes
May 21, 2025
2bcbafb to
3180e5d
Compare
4aa8fdb to
0664d08
Compare
pedromfcarvalho
previously approved these changes
May 27, 2025
jiaqiluo
requested changes
May 27, 2025
0664d08 to
7a1d83c
Compare
pedromfcarvalho
previously approved these changes
May 27, 2025
jiaqiluo
requested changes
May 27, 2025
7a1d83c to
902d6f4
Compare
jakefhyde
requested changes
May 27, 2025
…iling to delete firewall rules.
902d6f4 to
0f703cc
Compare
jiaqiluo
approved these changes
May 28, 2025
jakefhyde
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rancher#49681
This PR updates the GCE driver so that it can be used by Rancher. Primary changes include,
GOOGLE_APPLICATION_CREDENTIALS_ENCODED_JSONenvironment variable toGOOGLE_AUTH_ENCODED_JSON, and no falls back to using the plain text value if the value is not base64 encoded. This is the primary change required to use this driver in Rancher.google-external-firewall-rule-prefixflag must be provided as well as one or more instances ofgoogle-open-portgoogle-internal-firewall-rule-prefixflag is provided, a network firewall rule will be generated to allow for nodes to communicate with one another using a set list of ports. If additional internal only ports are required, users can create additional firewall rules and specify the associated network tags when creating the VM.I've tested this both in Rancher and using the CLI, I've also updated the existing unit tests and added a few more cases.