Skip to content

[DNM] sqlcache: serialize write transactions to prevent SQLITE_BUSY under concurrent writers #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rohitsuse wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[DNM] sqlcache: serialize write transactions to prevent SQLITE_BUSY under concurrent writers #1232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/sqlcache/db/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,11 @@ func (c *client) WithTransaction(ctx context.Context, forWriting bool, f WithTra
}

func (c *client) withTransaction(ctx context.Context, forWriting bool, f WithTransactionFunction) error {
if forWriting {
c.writeMu.Lock()
defer c.writeMu.Unlock()
}

c.connLock.RLock()
// note: this assumes _txlock=immediate in the connection string, see NewConnection
tx, err := c.beginTX(ctx, forWriting)
Expand Down Expand Up @@ -162,6 +167,7 @@ type client struct {
Client
conn Connection
connLock sync.RWMutex
writeMu sync.Mutex
encryptor Encryptor
decryptor Decryptor
encoding encoding
Expand Down