[DNM] Fix panic when sorting non-SQL lists by a boolean field (rancher/rancher#55593)#1235
Open
rohitsakala wants to merge 1 commit into
Open
[DNM] Fix panic when sorting non-SQL lists by a boolean field (rancher/rancher#55593)#1235rohitsakala wants to merge 1 commit into
rohitsakala wants to merge 1 commit into
Conversation
b650be7 to
7b71c9a
Compare
tomleb
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Sorting a non-SQL list by a boolean field panics and kills the request handler, so Cluster Explorer renders blank:
Cause
SortListdid an uncheckedval.(string)on values fromdata.GetValueFromAny, but sortable fields aren't always strings — e.g.metadata.state.error(a bool, behind the dashboard's State column). Regressed in #618, which dropped the earlierconvert.ToString(...). Non-SQL path only; the SQL cache sorts viaORDER BY.Fix
Restore
convert.ToString(val); add aTestSortListregression case for boolean/missing fields.Fixes rancher/rancher#55593