Scope release workflow globs to build artifacts - #111
Merged
Conversation
`uv build` writes a `dist/.gitignore` (containing `*`) to keep its output directory clean; the previous `dist/*` glob attached it to the GitHub Release as a stray `default.gitignore` asset. Target `dist/*.whl` and `dist/*.tar.gz` explicitly in both the upload-artifact and gh-release steps so only the real build artifacts ship.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
v0.1.0release published correctly but included a straydefault.gitignore(1 byte) asset. Cause:uv buildwrites adist/.gitignore(containing*) to keep its output directory clean, and thedist/*glob in bothupload-artifactandaction-gh-releasepicked it up.Fix
Scope both globs to the actual build artifacts —
dist/*.whlanddist/*.tar.gz— so the.gitignoreis never attached.Cleanup already done
The stray
default.gitignorewas deleted from the publishedv0.1.0release, which now contains only the two correct artifacts:vesper-0.1.0-py3-none-any.whlvesper-0.1.0.tar.gzThis PR prevents recurrence on future releases.
Verification