Skip to content

Use core function#29

Draft
Jade-GG wants to merge 21 commits into
masterfrom
feature/use-core-mapping-function
Draft

Use core function#29
Jade-GG wants to merge 21 commits into
masterfrom
feature/use-core-mapping-function

Conversation

@Jade-GG

@Jade-GG Jade-GG commented Mar 13, 2026

Copy link
Copy Markdown
Collaborator

ref: RAP-1830

Note that this change requires Rapidez v5.

Add Statamic 6 support for Rapidez v5
@BobWez98

Copy link
Copy Markdown
Member

maybe retarget to feature/statamic-6 ?

BobWez98
BobWez98 previously approved these changes Mar 16, 2026
@Jade-GG Jade-GG changed the base branch from master to feature/statamic-6 March 16, 2026 10:50
@Jade-GG

Jade-GG commented Mar 16, 2026

Copy link
Copy Markdown
Collaborator Author

Also now contains #28 because apparently that's not in the statamic 6 branch yet 👀

royduin
royduin previously approved these changes Mar 17, 2026
@royduin

royduin commented Mar 17, 2026

Copy link
Copy Markdown
Member

So this is Rapidez v5 only? And what about #28? That one is merged and for v4?

@Jade-GG

Jade-GG commented Mar 18, 2026

Copy link
Copy Markdown
Collaborator Author

So this is Rapidez v5 only? And what about #28? That one is merged and for v4?

Yes, this new functionality only exists in v5.

How to deal with #28 is actually a tricky question here. Should we revert that in the v4 branch and require upgrading to Statamic 6 to always be combined with Rapidez v5? Or do we make an in-between version that supports v5? My own take would be to do the former and revert it after this branch is merged.

indykoning
indykoning previously approved these changes Apr 7, 2026

@indykoning indykoning left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts

@Jade-GG Jade-GG marked this pull request as draft April 21, 2026 09:57
Base automatically changed from feature/statamic-6 to master June 25, 2026 14:11
@royduin royduin dismissed stale reviews from indykoning, BobWez98, and themself June 25, 2026 14:11

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants