Update DLPack to v1.0 - #5602
Conversation
|
/ok to test e66cbff |
@alexbarghi-nv, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/ |
|
/ok to test e55cbff |
|
/ok to test 7550843 |
This reverts commit 83f8feb.
|
/ok to test 7760d21 |
|
/ok to test 7d0fee5 |
There was a problem hiding this comment.
This is blocked without a DLPack update in cuDF.
error libmamba Could not solve for environment specs
The following packages are incompatible
├─ cuda-version =13.3 * is requested and can be installed;
├─ dlpack >=1.0,<1.1 * is requested and can be installed;
└─ libcudf =26.8,>=0.0.0a0 * is not installable because there are no viable options
├─ libcudf [26.08.00a943|26.08.00a944|...|26.08.00a988] would require
│ └─ cuda-version >=12,<13.0a0 *, which conflicts with any installable versions previously reported;
└─ libcudf [26.08.00a943|26.08.00a944|...|26.08.00a988] would require
└─ dlpack >=0.8,<1.0 *, which conflicts with any installable versions previously reported.
However, cuDF is frozen for 26.08. The version discrepancy is blocking our CCCL-RAPIDS CI, which is one of the places where we need to support "unified" environments with all of RAPIDS.
We need to revert NVIDIA/cuvs#2354 for 26.08 and retarget this DLPack update to 26.10. As a part of that, we also need to make sure we are following DLPack practices for version stability:
Starting DLPack 1.0, the DLManagedTensorVersioned struct should be used and the existing DLManagedTensor struct is considered deprecated, though a library should try to support both during the transition period if possible.
For the future, it would be helpful to document the motivation for cross-library dependency changes like this with an issue in https://github.com/rapidsai/build-planning/issues. The motivation for this update is not specified in this PR or in the cuVS PR.
# Conflicts: # conda/environments/all_cuda-129_arch-aarch64.yaml # conda/environments/all_cuda-129_arch-x86_64.yaml # conda/environments/all_cuda-133_arch-aarch64.yaml # conda/environments/all_cuda-133_arch-x86_64.yaml
|
Superseded by #5590, which now includes the DLPack v1.0 CMake fallback, the |
Summary
>=1.0,<1.1independencies.yamlrapids-dependency-file-generator1.21.0Impact
cuGraph builds and downstream development environments now consistently use the DLPack 1.0 release series, while avoiding unvalidated changes from 1.1 and later.
Release target
This PR now targets
mainfor the 26.10 release. It was retargeted fromrelease/26.08so the DLPack 1.x migration can be coordinated across RAPIDS projects outside the 26.08 code freeze. The cross-project support plan is tracked in rapidsai/build-planning#308.Validation
rapids-dependency-file-generatorand verified the output is idempotentdependencies.yamland all generatedall_*.yamlenvironment files with PyYAMLgit diff --check>=1.0,<1.1constraintConstraints