Skip to content

Update DLPack to v1.0 - #5602

Closed
alexbarghi-nv wants to merge 6 commits into
mainfrom
agent/update-dlpack-v1
Closed

Update DLPack to v1.0#5602
alexbarghi-nv wants to merge 6 commits into
mainfrom
agent/update-dlpack-v1

Conversation

@alexbarghi-nv

@alexbarghi-nv alexbarghi-nv commented Jul 22, 2026

Copy link
Copy Markdown
Member

Summary

  • require DLPack >=1.0,<1.1 in dependencies.yaml
  • update the CMake fallback tag/minimum version to v1.0
  • regenerate all checked-in conda environment files with rapids-dependency-file-generator 1.21.0

Impact

cuGraph builds and downstream development environments now consistently use the DLPack 1.0 release series, while avoiding unvalidated changes from 1.1 and later.

Release target

This PR now targets main for the 26.10 release. It was retargeted from release/26.08 so the DLPack 1.x migration can be coordinated across RAPIDS projects outside the 26.08 code freeze. The cross-project support plan is tracked in rapidsai/build-planning#308.

Validation

  • reran rapids-dependency-file-generator and verified the output is idempotent
  • parsed dependencies.yaml and all generated all_*.yaml environment files with PyYAML
  • ran git diff --check
  • verified all generated conda environments use the >=1.0,<1.1 constraint

Constraints

@copy-pr-bot

copy-pr-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@alexbarghi-nv
alexbarghi-nv marked this pull request as ready for review July 22, 2026 21:44
@alexbarghi-nv
alexbarghi-nv requested review from a team as code owners July 22, 2026 21:44
@alexbarghi-nv
alexbarghi-nv requested a review from jameslamb July 22, 2026 21:44
@alexbarghi-nv alexbarghi-nv self-assigned this Jul 22, 2026
@alexbarghi-nv alexbarghi-nv added improvement Improvement / enhancement to an existing function breaking Breaking change labels Jul 22, 2026
@alexbarghi-nv

Copy link
Copy Markdown
Member Author

/ok to test e66cbff

@copy-pr-bot

copy-pr-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

/ok to test e66cbff

@alexbarghi-nv, there was an error processing your request: E2

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/

@alexbarghi-nv

Copy link
Copy Markdown
Member Author

/ok to test e55cbff

@alexbarghi-nv alexbarghi-nv added the DO NOT MERGE Hold off on merging; see PR for details label Jul 22, 2026
@alexbarghi-nv

Copy link
Copy Markdown
Member Author

/ok to test 7550843

@alexbarghi-nv

Copy link
Copy Markdown
Member Author

/ok to test 7760d21

@alexbarghi-nv

Copy link
Copy Markdown
Member Author

/ok to test 7d0fee5

@bdice bdice left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is blocked without a DLPack update in cuDF.

error    libmamba Could not solve for environment specs
    The following packages are incompatible
    ├─ cuda-version =13.3 * is requested and can be installed;
    ├─ dlpack >=1.0,<1.1 * is requested and can be installed;
    └─ libcudf =26.8,>=0.0.0a0 * is not installable because there are no viable options
       ├─ libcudf [26.08.00a943|26.08.00a944|...|26.08.00a988] would require
       │  └─ cuda-version >=12,<13.0a0 *, which conflicts with any installable versions previously reported;
       └─ libcudf [26.08.00a943|26.08.00a944|...|26.08.00a988] would require
          └─ dlpack >=0.8,<1.0 *, which conflicts with any installable versions previously reported.

However, cuDF is frozen for 26.08. The version discrepancy is blocking our CCCL-RAPIDS CI, which is one of the places where we need to support "unified" environments with all of RAPIDS.

We need to revert NVIDIA/cuvs#2354 for 26.08 and retarget this DLPack update to 26.10. As a part of that, we also need to make sure we are following DLPack practices for version stability:

Starting DLPack 1.0, the DLManagedTensorVersioned struct should be used and the existing DLManagedTensor struct is considered deprecated, though a library should try to support both during the transition period if possible.

For the future, it would be helpful to document the motivation for cross-library dependency changes like this with an issue in https://github.com/rapidsai/build-planning/issues. The motivation for this update is not specified in this PR or in the cuVS PR.

@alexbarghi-nv
alexbarghi-nv changed the base branch from release/26.08 to main July 27, 2026 17:42
# Conflicts:
#	conda/environments/all_cuda-129_arch-aarch64.yaml
#	conda/environments/all_cuda-129_arch-x86_64.yaml
#	conda/environments/all_cuda-133_arch-aarch64.yaml
#	conda/environments/all_cuda-133_arch-x86_64.yaml
@alexbarghi-nv

Copy link
Copy Markdown
Member Author

Superseded by #5590, which now includes the DLPack v1.0 CMake fallback, the dlpack>=1.0,<1.1 dependency constraint, and regenerated 26.10 environment files.

@alexbarghi-nv
alexbarghi-nv deleted the agent/update-dlpack-v1 branch July 27, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Breaking change DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants