Conversation
Add calibrated tuning for the IMX283 sensor for pisp. Update the vc4 tuning file to match the new calibration. Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
The IMX283 uses a gain delay of 1 instead of the current value of 2 as defined in the sensor properties. Fix it. Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
|
Don't think so - let's go for it! |
|
Merging seems good here - I'm trying to merge upstream too - I took some images with the OneInchEye Will sent me some time ago - it's v1.3 ... and I get somewhat reddish images .. @naushir Do you know if the module you used for tuning had an IR Cut filter in place? Will tells me there was likely something in the packaging that I didn't put it. ... I also just realised there was a sensor plastic cover that I had never removed ! haha |
|
Hard to quantify - but there's something wrong with the 'reds'? |
|
@kbingham is this on a pi4 or pi5? The sensor I have does have an IR filter in place - (so the non-no-IR type 😄 ) |
|
That's captured on the Pi5 - Thanks - clarifying the IR filter is in place can probably account for the red-differences or at least be enough reason to not trust my comparison ! I'm going to have to dig into my camera box to see if I can find a small IR filter that I would have been sent two years ago ... eeep |
|
|
|
@naushir Might be worth waving Nick's IR lamp at it. I have a feeling our office windows might filter out IR. |
|
This is now pointing at my white painted wall background! (I'm in a different colour t-shirt from yesterday though) |
|
That's definitely capturing IR. Mine does have a filter over the sensor in the housing. |
|
Yeah - your picture is way better than mine ;-)
If I get too close to the lens things go /really/ red... I'm in an orange t-shirt. I'm really thinking I've got something wrong on my end here ... |
Ok - then I'll stop adding noise - and try to find the filter ... thanks. |
|
I will likely have to take the imaging sins I have just committed to the grave ... but there is now an IR cut filter "in front" of the sensor to the best of my knowledge and my walls are once again white! |
|
Merged to libcamera master too - with a small typo fixed in the title of the commit message at https://git.libcamera.org/libcamera/libcamera.git/commit/?id=aca8b701ac5645aaf13e2334c4c9e7610d4128a2 |
|
@naushir I realised there was no overlay support for IMX283 in the RPi kernel yet - I assume you managed to throw something together for the calibrations already, but to help get this camera directly supported I've pushed my version to a PR at raspberrypi/linux#6869 |
|
Yes I made an overlay file that I was going to push later. Will just use your PR instead. |
3 participants
@davidplowman any objections or should we merge this now?