hevc_d: Put command FIFO into coherent memory#6946
Closed
jc-kynesim wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Fixes a long standing (years) issue where very occasionally you get a bad frame out of the decoder that looks like it used the wrong reference frames. |
Change command FIFO alloction to be from dma coherent memory rather than from generic kernel memory that we map and unmap. This removes a potential issue with unmap in an IRQ tail. In general it should also be faster as it avoids the overhead inherent in map and unmap and most streams only create short command streams. Signed-off-by: John Cox <jc@kynesim.co.uk>
jc-kynesim
force-pushed
the
dev/6.12/hevc_cmd_coherent_1
branch
from
e2e5ca2 to
712274e
Compare
Contributor
|
@jc-kynesim Is this 6.12 PR now obsolete with the changes for the mainline patchset? Can we close it? |
Contributor
Author
|
This patch is incorporated with the mainline stuff |
Contributor
|
Closing then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change command FIFO alloction to be from dma coherent memory rather than from generic kernel memory that we map and unmap. This removes a potential issue with unmap in an IRQ tail. In general it should also be faster as it avoids the overhead inherent in map and unmap and most streams only create short command streams.