Skip to content

feat: edit profile - [CU-869atcbxt] - #60

Merged
HelanaNady merged 44 commits into
devfrom
feat/edit-profile
Nov 3, 2025
Merged

feat: edit profile - [CU-869atcbxt]#60
HelanaNady merged 44 commits into
devfrom
feat/edit-profile

Conversation

@HelanaNady

@HelanaNady HelanaNady commented Oct 30, 2025

Copy link
Copy Markdown
Member

Please keep in mind this code will 100% get refactored in a future PR after the current phase, there were common components between create profile and edit

@HelanaNady
HelanaNady changed the base branch from main to dev October 30, 2025 21:37
@HelanaNady HelanaNady changed the title Feat/edit profile feat: edit profile - [CU-869atcbxt] Oct 30, 2025
@Exo1i

Exo1i commented Oct 30, 2025

Copy link
Copy Markdown
Member

Task linked: CU-869atcbxt Edit profile

@HelanaNady HelanaNady closed this Oct 30, 2025
@HelanaNady HelanaNady reopened this Oct 30, 2025
@HelanaNady HelanaNady closed this Oct 30, 2025
@HelanaNady HelanaNady reopened this Oct 30, 2025
@HelanaNady
HelanaNady marked this pull request as ready for review October 31, 2025 22:21
@github-actions

Copy link
Copy Markdown

Testers Checklist

General

  • Validation for every input
  • Persistent try/catch blocks
  • No lack of documentation
  • Localization

Cross platform

  • Caching (if applicable)
  • Responsiveness
  • Loading indicators & skeleton loaders
  • Optimistic loading (if applicable)

@HelanaNady
HelanaNady force-pushed the feat/edit-profile branch 5 times, most recently from 3f1346c to 1859a95 Compare November 1, 2025 18:27
im-saif
im-saif previously approved these changes Nov 1, 2025

@im-saif im-saif left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks for your great effort on this!

@Exo1i

Exo1i commented Nov 2, 2025

Copy link
Copy Markdown
Member

Thanks alot Helana! This will be merged after PR #69

AhmedSobhy01
AhmedSobhy01 previously approved these changes Nov 2, 2025
AhmedSobhy01
AhmedSobhy01 previously approved these changes Nov 2, 2025
@Exo1i
Exo1i force-pushed the feat/edit-profile branch from fb2add0 to 66dc1f3 Compare November 3, 2025 14:25
@Exo1i
Exo1i requested a review from AhmedSobhy01 November 3, 2025 15:21
@github-actions

github-actions Bot commented Nov 3, 2025

Copy link
Copy Markdown

Unit Tests Coverage Report

Coverage after merging feat/edit-profile into dev will be
87.40%
Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
src/components/profile
   Banner.tsx97.30%94.44%100%100%37
   ProfileHeader.tsx81.36%76.92%62.50%92%100, 42, 42, 57, 62–63, 76, 94
   ProfileInfo.tsx60.42%80%60%43.48%115, 29, 31, 34, 34, 34, 37–38, 40–41, 45, 47, 47, 47–48, 50, 53
src/components/utils
   profile.ts75%42.86%100%86.67%11, 13, 13, 13, 2, 24
src/hooks/profile
   useBioParser.tsx95.24%85.71%100%100%58, 73
   useProfile.tsx66.67%50%66.67%71.43%14–16
src/screens/auth/signin
   password.tsx80.60%55.56%75%92.68%145, 175, 64, 68, 93, 93, 93–94, 94, 94, 97
src/screens/profile
   EditProfileScreen.tsx55.79%44.14%61.70%61.45%102–104, 108, 125, 129, 145, 156–157, 170, 178–179, 183, 189, 191, 193, 199, 199, 199, 199, 199–201, 203, 228, 230–231, 233, 233, 233, 236, 238–239, 239, 239–240, 242, 242, 242, 242, 242, 244, 244, 244–245, 245, 245–246, 248, 252, 252, 252–253, 253, 257, 261, 261, 261–262, 266, 269, 269, 269, 271, 274, 280, 284, 286, 286, 286–287, 287, 287, 290, 290, 290–291, 291, 291, 296, 298–304, 324, 329–330, 342, 342, 342, 342, 342, 344, 346, 351–352, 357–358, 392–393, 401, 467, 469, 510, 512, 525, 534–537, 55, 562, 57, 57, 575, 575, 578, 578, 61–62, 71–74, 82, 88–89, 92
   ProfilePicScreen.tsx46.88%41.67%38.46%51.28%103, 108, 135, 140, 158, 46, 55–56, 60–61, 65–66, 66, 66, 70–72, 72, 72–73, 75–77, 79, 81, 96
   ProfileScreen.tsx0%0%0%0%14–17, 17, 17, 19, 21, 33
src/screens/profile/profileTabs
   ProfileLikesScreen.tsx0%100%0%0%2–3
   ProfileMediaScreen.tsx0%100%0%0%2–3
   ProfilePostsScreen.tsx0%100%0%0%2–3
   ProfileRepliesScreen.tsx0%100%0%0%2–3
src/services
   me.ts9.38%0%25%10%15–16, 26, 29–30, 30, 30, 33–34, 34, 34, 36, 42, 46, 50, 53–54, 54, 54, 57–58, 58, 58, 60, 66–67
   user.ts100%100%100%100%
src/stores
   sessionStore.ts93.25%81.25%93.75%98.08%122, 122, 122, 164, 175, 247, 272, 272, 272, 291, 291, 291, 328, 75, 78
   userStore.ts100%100%100%100%
src/utils/navigation
   routeNames.ts100%100%100%100%

@HelanaNady
HelanaNady merged commit de8b953 into dev Nov 3, 2025
5 checks passed
AhmedSobhy01 pushed a commit that referenced this pull request Nov 3, 2025
Co-authored-by: Saif <saifeldin402@gmail.com>
Co-authored-by: hxed <121557650+Exo1i@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants