Skip to content

feat(tweet): repost a tweet with a quote - [CU-869bafw12] - #132

Merged
habibayman merged 16 commits into
devfrom
feat/repost-tweet
Dec 3, 2025
Merged

feat(tweet): repost a tweet with a quote - [CU-869bafw12]#132
habibayman merged 16 commits into
devfrom
feat/repost-tweet

Conversation

@habibayman

@habibayman habibayman commented Nov 27, 2025

Copy link
Copy Markdown
Member

Description

Added the option to repost a tweet with quote.
Uses the same endpoints as posting a normal tweet.

I refactored the original tweet actions component to show dropdown menu for reposting options:
a) preserves old behavior of toggling a repost, just in a new shape:

Screencast.from.2025-11-28.03-01-13.webm

b) a new quote a tweet dialog editor:

Screencast.from.2025-11-28.03-01-28.webm

Reviewer Guidance

Unfortunately you won't be able to see the posted quoted tweet now because it hasn't been implemented yet, once @Abdallah-farag27 implements it, we will be.

for now what you can do is to view the response of the sent request to /tweets in the networks tab and make sure it returns a "quoteToTweetId"

image

Note

Maybe we can use the quoted tweet view that will be implemented for the tweet here inside the composer too. Since right now this isn't exactly 1:1 with twitter

@AhmedAmrNabil

Copy link
Copy Markdown
Collaborator

Task linked: CU-869bafw12 repost a tweet with a quote

@habibayman
habibayman marked this pull request as ready for review November 28, 2025 00:27
@github-actions

Copy link
Copy Markdown

Testers Checklist

General

  • Validation for every input
  • Persistent try/catch blocks
  • No lack of documentation
  • Localization

Frontend

  • Caching (if applicable)
  • Responsiveness for all screens
  • Loading indicators & skeleton loaders
  • Optimistic loading (if applicable)
  • No warnings in console

@github-actions

Copy link
Copy Markdown

Unit Tests Coverage Report

Coverage after merging feat/repost-tweet into dev will be
79.15%
Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
app/components/tweet
   TweetActionButtons.vue94.59%100%72.73%95.45%144, 181, 183
   TweetDefaultCard.vue94.39%95.56%77.78%96.23%105, 105, 105–106
   TweetMedia.vue100%100%100%100%
app/components/tweet/composer
   MediaSlideshow.vue92.06%79.17%100%100%42, 47, 74, 92, 95
   QuoteTweetDialog.vue72.22%75%50%80%22–23, 28
   Toolbar.vue95.18%87.88%100%100%58, 65, 79, 97
   TweetComposer.vue74.29%70%66.67%77.27%49, 51, 54–57, 67, 91
   TweetEditor.vue89.92%81.08%100%92.54%102–103, 103–104, 108, 120, 146, 54–55, 73, 97–98
app/components/ui/dialog
   DialogContent.vue80.95%100%50%81.82%39–40
app/components/ui/dropdown-menu
   DropdownMenuContent.vue100%100%100%100%
   DropdownMenuItem.vue85.71%50%100%100%31
app/composables
   useTweetComposer.ts91.09%80%100%96.49%109, 31–32, 34–35, 43, 60, 77, 83

@habibayman

Copy link
Copy Markdown
Member Author

Update: the quoted tweet view is in progress in #136 but is expected to have some delay.

This PR shouldn't be held pending on it because everything here works already! it just can get a little prettier ✨
I will use the <QuotedTweetView /> later when it's merged but this PR should be merged and pass on QA normally without any delay.

@habibayman
habibayman merged commit 0072f48 into dev Dec 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants