Skip to content

feat: implement user profile page with info - [CU-869awe6gv] - #30

Merged
Hussein-Mohamed1 merged 68 commits into
devfrom
feat/profile-info
Oct 30, 2025
Merged

feat: implement user profile page with info - [CU-869awe6gv]#30
Hussein-Mohamed1 merged 68 commits into
devfrom
feat/profile-info

Conversation

@Hussein-Mohamed1

Copy link
Copy Markdown
Member

No description provided.

@Hussein-Mohamed1
Hussein-Mohamed1 marked this pull request as ready for review October 23, 2025 17:58
@Hussein-Mohamed1 Hussein-Mohamed1 changed the title feat: implement user profile page with info sections feat: implement user profile page with info - [CU-869awe6gv] Oct 23, 2025
@AhmedAmrNabil

Copy link
Copy Markdown
Collaborator

Task linked: CU-869awe6gv User Profile

Comment thread app/composables/useUserProfile.ts Outdated
Comment thread mocks/handlers/userProfile.ts
Comment thread public/cover.jpg Outdated
Comment thread package.json Outdated
@habibayman

Copy link
Copy Markdown
Member

Thank you for your work!

  1. The "posts" tab in the profile seems to break the navigation. Watch the video:
Screencast.from.2025-10-24.21-24-39.webm
  1. It seems like the "likes" tab has also disappeared!

  2. Please add a link to the mock user's data to preview the style of the link in the profile.

image

@github-actions

Copy link
Copy Markdown

Testers Checklist

General

  • Validation for every input
  • Persistent try/catch blocks
  • No lack of documentation
  • Localization

Frontend

  • Caching (if applicable)
  • Responsiveness for all screens
  • Loading indicators & skeleton loaders
  • Optimistic loading (if applicable)
  • No warnings in console

@Hussein-Mohamed1

Copy link
Copy Markdown
Member Author

Thanks again!

1. [BLOCKING] The tabs in the profile layout are completely broken: all 3 tabs lead to the posts view. and where is even **the fourth tab (likes)** ? 😭

broken-tabs.webm

2. [BLOCKING] I still can't find the preview of having links in the profile. Maybe this screenshot will make it clearer.
image
3. [BLOCKING] Please fix the tab highlighting for side bar buttons. for more info please check description & demo video in  [fix: use i18n routing prefix strategy - [CU-869b0233f] #45](https://github.com/AhmedAmrNabil/raven-frontend/pull/45)

4. [Blocking] Use the user store I created and that you can find in your branch by solving the merge conflicts above. I will try to leave explanatory comments in the code on how this change should look like. All in all, I'm for sure also available for extra consultation on Discord.

Thanks again!

1. [BLOCKING] The tabs in the profile layout are completely broken: all 3 tabs lead to the posts view. and where is even **the fourth tab (likes)** ? 😭

broken-tabs.webm

2. [BLOCKING] I still can't find the preview of having links in the profile. Maybe this screenshot will make it clearer.
image
3. [BLOCKING] Please fix the tab highlighting for side bar buttons. for more info please check description & demo video in  [fix: use i18n routing prefix strategy - [CU-869b0233f] #45](https://github.com/AhmedAmrNabil/raven-frontend/pull/45)

4. [Blocking] Use the user store I created and that you can find in your branch by solving the merge conflicts above. I will try to leave explanatory comments in the code on how this change should look like. All in all, I'm for sure also available for extra consultation on Discord.

thank you for your review.
i have resolved these issues, and i am now using the user store.

habibayman
habibayman previously approved these changes Oct 30, 2025

@habibayman habibayman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thanks for the patience & work!

A follow up PR will be opened to integrate this part with other standalone user profile features.

@AmrSamy59

Copy link
Copy Markdown
Member

profile cover must maintain aspect ratio and always show the same details on any screen, not revealing more details on smaller screen because of increasing the canvas width

Recording.2025-10-30.215621.mp4

a real refrence from X:

Recording.2025-10-30.215651.mp4

notice the entire section preserves aspect ratio resizing everything including the profile picture.

@AmrSamy59

Copy link
Copy Markdown
Member

profile cover must maintain aspect ratio and always show the same details on any screen, not revealing more details on smaller screen because of increasing the canvas width

Recording.2025-10-30.215621.mp4
a real refrence from X:

Recording.2025-10-30.215651.mp4
notice the entire section preserves aspect ratio resizing everything including the profile picture.

Will be resolved in a later PR (Issue: CU-869b0h7nn)

@github-actions

Copy link
Copy Markdown

Unit Tests Coverage Report

Coverage after merging feat/profile-info into dev will be
63.51%
Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
app/components/SideBar/Left
   Tab.vue89.47%66.67%100%100%11–12
   index.vue87.50%50%100%100%23
app/components/SideBar/Right
   index.vue100%100%100%100%
app/components/SideBar/Right/PreviewCard
   index.vue100%100%100%100%
   item.vue100%100%100%100%
app/components/profile
   ProfileAvatarSection.vue100%100%100%100%
   ProfileCover.vue100%100%100%100%
   ProfileDetails.vue100%100%100%100%
   ProfileInfo.vue100%100%100%100%
app/composables
   useUserProfile.ts0%100%0%0%11, 3, 8
app/layouts
   default.vue100%100%100%100%
   profile.vue94.12%87.50%100%100%28
app/pages/profile
   index.vue100%100%100%100%
app/pages/profile/[username]
   index.vue100%100%100%100%
app/stores
   user.ts40.74%12.50%33.33%61.54%45, 45, 45, 57, 59, 59, 59–60, 67, 67, 67, 71
app/utils
   cleanUrl.ts100%100%100%100%
   date.ts100%100%100%100%
   index.ts100%100%100%100%
server/api/users/[username]/profile
   index.get.ts0%0%0%0%11–14, 16, 16, 16–19, 19–20, 20, 25, 8

@Hussein-Mohamed1
Hussein-Mohamed1 merged commit 480d981 into dev Oct 30, 2025
8 checks passed
AhmedSobhy01 pushed a commit that referenced this pull request Nov 3, 2025
Co-authored-by: Habiba Ayman <137416623+habibayman@users.noreply.github.com>
Co-authored-by: habibayman <habibaayman2004@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants