feat(forgot-password): forgot password - [CU-869aqfgqb] - #37
Merged
Conversation
…erification and password reset
…end OTP, and reset functionalities
…oginService tests
…e functionalities
…p, and reset functionalities
mostafahassan04
requested review from
AhmedSobhy01,
AmrSamy59,
LoayAhmed304 and
im-saif
as code owners
October 23, 2025 19:59
Collaborator
|
Task linked: CU-869aqfgqb Forget password |
mostafahassan04
requested review from
Abdallah-farag27,
AhmedAmrNabil,
Hussein-Mohamed1 and
habibayman
October 23, 2025 20:03
AhmedAmrNabil
left a comment
AhmedAmrNabil
left a comment
Collaborator
There was a problem hiding this comment.
Great work Hassan :)
AhmedAmrNabil
previously approved these changes
Oct 26, 2025
Member
|
Why is the PR huge like that? |
Testers ChecklistGeneral
Frontend
|
AhmedAmrNabil
approved these changes
Oct 28, 2025
AmrSamy59
approved these changes
Oct 28, 2025
Unit Tests Coverage ReportCoverage after merging feat/forget-password into dev will be
Coverage Report for Changed Files
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
AhmedSobhy01
pushed a commit
that referenced
this pull request
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements a complete refactor and redesign of the authentication and password reset flows in the application. It introduces new Vue components for each step of the password reset process, updates the login and password forms to use improved validation and error handling, and adds new service layers for login and password management. The changes focus on improving UX, code maintainability, and validation accuracy.
Authentication flow improvements
Updated
IdentifierStep.vueandPasswordStep.vueto use stricter field validation withyup, improved error handling via toasters, and dynamic button states based on form validity. The forms now validate on change and disable submission when invalid or submitting. Also, error display logic was simplified and UI text was updated for clarity. [1] [2] [3] [4] [5] [6] [7]Refactored
FieldPassword.vueto support dynamic field names and placeholders, and to display validation error messages directly below the input. [1] [2]Password reset flow implementation
Added new components for each step of the password reset process:
FindAccount.vuefor user identification,SentCode.vuefor OTP verification, andChooseNewPassword.vuefor setting a new password. Each uses strong validation, disables submission when invalid, and provides clear error feedback. [1] [2] [3]Created a new password reset page (
password-reset/index.vue) that orchestrates the multi-step dialog, manages dialog state, and integrates the new components.Service layer additions
loginService.tsfor checking user existence and performing login, andpasswordService.tsfor handling password reset flows (user check, OTP verification, resend OTP, and password reset). These abstract API calls and improve separation of concerns. [1] [2]