Initial refactor for NSMenu for ARC and nullability (and a whole lot of TODO/FIXME comments) - #520
Closed
reactive-firewall wants to merge 10000 commits into
Closed
reactive-firewall wants to merge 10000 commits into
reactive-firewall wants to merge 10000 commits into
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch Notes
This code is still unpolished but now it should actually behave more like an NSMenu should.
... or it would if
NSMenuItemwas working 🤦 ... but let's take it one class at a time.Impacted GHI
NSMenu#518NSMenuneedsNSMenuItemto be useful #519Misc. Comments:
TODOs andFIXMEs left for future iterations