Introduce clang-format as linter, apply linting, add CI

[gmelikov]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @gmelikov, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances code quality and maintainability by establishing and enforcing a consistent coding style using clang-format. It introduces a dedicated linting script and applies the formatting rules to all relevant C/C++ files, ensuring a uniform appearance and easier readability across the project. This foundational change will streamline future development and code reviews by eliminating style-related discussions.

Highlights

• Clang-Format Integration: Introduced clang-format as the standard code linter for C/C++ files to ensure consistent coding style.
• Automated Linting Script: Added a new shell script (.github/tools/clang-format.sh) that automatically checks and applies clang-format rules across the codebase.
• Codebase Formatting: Applied clang-format to all existing C/C++ source and header files, standardizing their appearance and improving readability.
• CI Enforcement: Implemented continuous integration checks to enforce clang-format rules, ensuring all future code changes adhere to the defined style.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/linter.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces clang-format for code linting and applies formatting changes across the codebase. While the formatting changes are good, I've found a critical security vulnerability and a bug in the new clang-format.sh script. Using eval with user-controllable input is dangerous, and the find command is used incorrectly. I've provided a safer and more correct implementation. Additionally, I've identified several memory leaks and incorrect exit codes in the examples/ost_client.c file, which were surfaced by the formatting changes. Please review the suggested fixes.