Skip to content

add: dist workflow#13

Merged
VasilyStepanov merged 3 commits intomainfrom
add/dist
Jan 2, 2026
Merged

add: dist workflow#13
VasilyStepanov merged 3 commits intomainfrom
add/dist

Conversation

@VasilyStepanov
Copy link
Copy Markdown
Member

No description provided.

@VasilyStepanov VasilyStepanov self-assigned this Jan 2, 2026
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @VasilyStepanov, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the project's distribution workflow by adjusting the build configuration. It streamlines the compilation process by excluding examples and ensures that the README.md file is correctly prepared for distribution, while its generated version is kept out of version control.

Highlights

  • Distribution Workflow: A new distribution workflow has been implemented, configuring Makefile.am to properly handle README generation from README.md and ensure its inclusion in distribution archives.
  • Build Process Simplification: The examples directory has been removed from the SUBDIRS in Makefile.am, which simplifies the main build and distribution process.
  • Git Ignore Update: The .gitignore file has been updated to include /README, preventing the generated README file from being tracked by Git.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/dist.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to add a distribution workflow by updating the autotools configuration. The changes in Makefile.am introduce rules to generate a plain text README from README.md for the distribution. While the intent is good, the current implementation has issues with out-of-tree builds and doesn't correctly include the generated README in the distribution package. I've suggested a more idiomatic automake approach using dist-hook to address this.

Comment thread Makefile.am
Copy link
Copy Markdown
Member

@gmelikov gmelikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@VasilyStepanov VasilyStepanov merged commit 1947775 into main Jan 2, 2026
2 checks passed
@VasilyStepanov VasilyStepanov deleted the add/dist branch January 2, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants