Skip to content

Commit 6a6c735

Browse files
committed
Print real git fetch errors instead of silencing stderr
Use 'git fetch -q' rather than redirecting stderr to /dev/null, so a genuine fetch failure (missing branch, network, permissions) surfaces instead of degrading to the generic 'could not determine merge-base' message. Matches the fetch in .buildkite/doc.rayci.yml. Addresses reviewer feedback. Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
1 parent 855d41b commit 6a6c735

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

ci/lint/validate_docs_go_scope.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ set -uo pipefail
5555
# ci/pipeline/determine_tests_to_run.py.
5656
base_branch="${BUILDKITE_PULL_REQUEST_BASE_BRANCH:-master}"
5757

58-
git fetch --depth=500 origin "${base_branch}" >/dev/null 2>&1 || true
58+
git fetch -q --depth=500 origin "${base_branch}" || true
5959
if ! base="$(git merge-base "origin/${base_branch}" HEAD 2>/dev/null)"; then
6060
echo "docs-go scope guard: could not determine merge-base with origin/${base_branch}; failing closed."
6161
exit 1

0 commit comments

Comments
 (0)