[rTextures] Use the render size not the screen size for screenshots - #5192
Merged
Conversation
… actual framebuffer size.
Owner
|
@JeffM2501 Good catch! Thanks for the review! |
psxdev
pushed a commit
to raylib4Consoles/raylib
that referenced
this pull request
Sep 19, 2025
… actual framebuffer size. (raysan5#5192)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The screenshot code is always applying the DPI scale to the image, even if the framebuffer was not created with that scale, thus if you have a DPI scale but are NOT doing DPI auto scaling and using the window at it's native resolution, the image will be too big.
The screenshot code should never use ScreenSize, it should use RenderSize, so that it gets the size of the framebuffer that it's saving. There should not be any need for High DPI logic here since this is just saving an existing framebuffer that has a fixed size.
This PR makes the change so that screenshots work in both modes on all platforms since it's just using the same size that the framebuffer was created with.