[rcore] Fix logging format for automation event capacity warning - #5986
Merged
Conversation
Owner
|
@GideonSerf Good catch! Thanks for the fix! Note that the events automation should be probably redesigned or at least disabled by default on config in the future... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The format specifiers and arguments in this log statement are mismatched:
The format string expects an integer followed by a string, but the arguments are passed as a string followed by an unsigned integer. If the automated event list reaches capacity, such as when 16,385 event lines are encountered, this mismatch can result in undefined behavior and potentially a crash.
This change swaps the arguments into the correct order and replaces
%iwith%uto match the unsigned type oflist.capacity.