Fix transmission of signals by Test Automation Executor#1116
Open
itiserik wants to merge 1 commit intorbei-etas:masterfrom
Open
Fix transmission of signals by Test Automation Executor#1116itiserik wants to merge 1 commit intorbei-etas:masterfrom
itiserik wants to merge 1 commit intorbei-etas:masterfrom
Conversation
The order of signals obtained by pMsg->GetSignalList( signalList ); is determined by keys of the map. In this case it is ISignal* and having items sorted on the address of a pointer makes no sense. Moreover on every invocation of GetSignalList() we get another map of pointers so perhaps there is a memory leak as well. The order of signals in ouSendData.m_odSignalDataList is determined by the signals present in the testsetup xml file and we cannot make any assumptions on this. So the signals in the signalList (containing startaddresses, endianess etc) must be matched to the ouSendData.m_odSignalDataList on signalName. The GetProperties (DBManager.dll ?) function previously used in un64GetBitMask did not initialize m_ouEndianess and this results in unpredictable results. For CAN this was the last place in BUSMASTER m_ouEndianess was used.
|
Can't build this commit or any in busmaster... Is it possible to get the .dll from you somehow? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The order of signals obtained by pMsg->GetSignalList( signalList ); is
determined by keys of the map. In this case it is ISignal* and
having items sorted on the address of a pointer makes no sense.
Moreover on every invocation of GetSignalList() we get another map of
pointers so perhaps there is a memory leak as well.
The order of signals in ouSendData.m_odSignalDataList is determined by the signals
present in the testsetup xml file and we cannot make any assumptions on this.
So the signals in the signalList (containing startaddresses, endianess etc)
must be matched to the ouSendData.m_odSignalDataList on signalName.
The GetProperties (DBManager.dll ?) function previously used in un64GetBitMask
did not initialize m_ouEndianess and this results in unpredictable results.
For CAN this was the last place in BUSMASTER m_ouEndianess was used.