Various reliability improvements - #1
Merged
Merged
Conversation
Owner
|
My apologies I didn't even see this pull request! (and i'm on github every day)... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found setting temperature to be flaky and the mapping of concepts to
water_heater(namely the "standby"/"warm" state) to be confusing.With these changes, Home Assistant now automatically detects if you are in "Guide" mode (which means you select between presets like green tea, pour over, black tea, etc. rather than turning the dial to choose a particular numerical temperature). If you have selected a temperature that is not in the Guide, it will disable Guide mode, turn the dial to select the temperature (with an algorithm that handles situations like under/overshoot), then re-enable Guide mode. If the temperature is a Guide preset, it will make only a few precise dial turns to select the temperature.
Let me know if you'd like me to break up these changes.