Skip to content

Scale connected body transform before serializing to JSON#1547

Merged
yoshikikanemoto merged 4 commits intoproductionfrom
scale-connected-body-transform
Mar 4, 2026
Merged

Scale connected body transform before serializing to JSON#1547
yoshikikanemoto merged 4 commits intoproductionfrom
scale-connected-body-transform

Conversation

@seanzhang15
Copy link
Copy Markdown
Collaborator

Similar to #1498, the PR applies fUnitScale to connected body's transform before serializing to JSON.

@seanzhang15
Copy link
Copy Markdown
Collaborator Author

@seanzhang15 seanzhang15 requested a review from Puttichai February 6, 2026 08:43
@Puttichai
Copy link
Copy Markdown
Collaborator

@seanzhang15 Don't we need similar scaling in ConnectedBodyInfo::DeserializeJSON as well?

@seanzhang15
Copy link
Copy Markdown
Collaborator Author

@seanzhang15 Don't we need similar scaling in ConnectedBodyInfo::DeserializeJSON as well?

Updated in fc059f6.

@Puttichai
Copy link
Copy Markdown
Collaborator

LGTM

@yoshikikanemoto
Copy link
Copy Markdown
Collaborator

@seanzhang15 can you merge production branch and bump patch version and add changelog?

@yoshikikanemoto yoshikikanemoto merged commit b415408 into production Mar 4, 2026
1 check passed
@yoshikikanemoto
Copy link
Copy Markdown
Collaborator

thanks!

@yoshikikanemoto yoshikikanemoto deleted the scale-connected-body-transform branch March 13, 2026 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants