Add uri to KinBodyInfo::SerializeJSON output#1550
Closed
eisoku9618 wants to merge 3 commits intoproductionfrom
Closed
Add uri to KinBodyInfo::SerializeJSON output#1550eisoku9618 wants to merge 3 commits intoproductionfrom
eisoku9618 wants to merge 3 commits intoproductionfrom
Conversation
yoshikikanemoto
approved these changes
Feb 27, 2026
Collaborator
yoshikikanemoto
left a comment
There was a problem hiding this comment.
Makes sense.
Do you see any problems? Further description about motivation can be found https://tiny.mujin.co.jp/lz998
Our tests are all green with this change + other changes in internal repos.
…o keep-referenceURI
Collaborator
|
saving uri into serialized data requires a lot of design changes and user flow changes when dealing with scene rename etc so closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sending
KinBodyto another process, we serialize it on the sender side asKinBodyInfoand deserialize on the receiver side. However,KinBodyInfo::SerializeJSONsupports_referenceUribut not_uriintentionally, so we have been working around this by copying_uriinto_referenceUribefore serialization in application code. The problem is that this overwrites the original_referenceUri, so the original value is lost. To avoid that, I would likeKinBodyInfo::SerializeJSONto support_urias well.Here is an example of the current application code for the sender and receiver sides.