Use == instead of EXPECT_EQ in testlib - #52796
Closed
avp wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78823354 |
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 23, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 23, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 23, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 23, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 23, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 23, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 23, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 23, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 23, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 23, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 23, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 23, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 23, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 23, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 23, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 23, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 23, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 23, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 23, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 23, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 23, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 23, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 23, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 23, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 23, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 25, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 25, 2025
Summary: X-link: react/react-native#52796 Pull Request resolved: facebook#1740 Pull Request resolved: facebook#1739 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78823354 |
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 25, 2025
Summary: X-link: react/react-native#52796 Pull Request resolved: facebook#1740 Pull Request resolved: facebook#1739 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 25, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 25, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 25, 2025
Summary: X-link: react/react-native#52796 Pull Request resolved: facebook#1740 Pull Request resolved: facebook#1739 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Differential Revision: D78823354
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78823354 |
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 25, 2025
Summary: X-link: react/react-native#52796 Pull Request resolved: facebook#1740 Pull Request resolved: facebook#1739 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Reviewed By: tsaichien Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 28, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Reviewed By: tsaichien Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 28, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Reviewed By: tsaichien Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 28, 2025
Summary: X-link: react/react-native#52796 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Reviewed By: tsaichien Differential Revision: D78823354
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 28, 2025
Summary: X-link: react/react-native#52796 Pull Request resolved: facebook#1740 Pull Request resolved: facebook#1739 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Reviewed By: tsaichien Differential Revision: D78823354
Summary: Pull Request resolved: react#52796 X-link: facebook/hermes#1740 X-link: facebook/hermes#1739 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Reviewed By: tsaichien Differential Revision: D78823354
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78823354 |
avp
added a commit
to avp/hermes
that referenced
this pull request
Jul 28, 2025
Summary: X-link: react/react-native#52796 Pull Request resolved: facebook#1740 Pull Request resolved: facebook#1739 The `EXPECT_EQ` was leading to potentially ambiguous use of `<<` when gtest tries to print information. Reviewed By: tsaichien Differential Revision: D78823354
Collaborator
|
This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label. |
react-native-bot
added
the
Stale
Collaborator
|
This PR was closed because it has been stalled for 7 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/hermes#1739
The
EXPECT_EQwas leading to potentially ambiguous use of<<whengtest tries to print information.
Differential Revision: D78823354