Fix JSI isArray method to match JS Array.isArray - #53998
Closed
tsaichien wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-bot
added
p: Facebook
Contributor
|
@tsaichien has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83391784. |
Summary: As the previous few diffs, JSI `isArray` API should follow `Array.isArray` from the JS spec. The current implementation does not consider Proxy objects, only Array exotic objects. Reviewed By: lavenzg Differential Revision: D83391784
tsaichien
force-pushed
the
export-D83391784
branch
from
October 1, 2025 00:00
a60271a to
3779f81
Compare
Contributor
|
This pull request has been merged in 6031905. |
Collaborator
|
This pull request was successfully merged by @tsaichien in 6031905 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
As the previous few diffs, JSI
isArrayAPI should followArray.isArrayfrom the JS spec.The current implementation does not consider Proxy objects, only Array
exotic objects.
Differential Revision: D83391784