Skip to content

Fix JSI isArray method to match JS Array.isArray #53998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tsaichien wants to merge 1 commit into from
Closed

Fix JSI isArray method to match JS Array.isArray #53998

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/react-native/ReactCommon/jsc/JSCRuntime.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1047,7 +1047,14 @@ void JSCRuntime::setPropertyValue(
}

bool JSCRuntime::isArray(const jsi::Object& obj) const {
return JSValueIsArray(ctx_, objectRef(obj));
// JSValueIsArray only returns true if the object is a JS array. There's no
// public JSC API equivalent to Array.isArray, so we call the JS function
// through JSI directly.
auto constRt = const_cast<JSCRuntime*>(this);
auto isArrayFn = constRt->global()
.getPropertyAsObject(*constRt, "Array")
.getPropertyAsFunction(*constRt, "isArray");
return isArrayFn.call(*constRt, obj).asBool();
}

bool JSCRuntime::isArrayBuffer(const jsi::Object& obj) const {
Expand Down
Loading