Enforce void return type for void return type in JS C++ TM spec - #53214
Closed
christophpurrer wants to merge 1 commit into
Closed
Enforce void return type for void return type in JS C++ TM spec#53214christophpurrer wants to merge 1 commit into
christophpurrer wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79980538 |
christophpurrer
force-pushed
the
export-D79980538
branch
from
August 11, 2025 21:50
91c621c to
528e28f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79980538 |
christophpurrer
force-pushed
the
export-D79980538
branch
from
August 11, 2025 21:53
528e28f to
4019942
Compare
christophpurrer
force-pushed
the
export-D79980538
branch
from
August 11, 2025 23:41
4019942 to
5230598
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79980538 |
christophpurrer
force-pushed
the
export-D79980538
branch
from
August 11, 2025 23:45
5230598 to
3b0b173
Compare
christophpurrer
force-pushed
the
export-D79980538
branch
from
August 12, 2025 01:33
3b0b173 to
6aa8316
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79980538 |
christophpurrer
force-pushed
the
export-D79980538
branch
from
August 12, 2025 16:46
6aa8316 to
c40420d
Compare
…t#53214) Summary: Pull Request resolved: react#53214 Changelog: [Fixed] [General] Enforce void return type for void return type in JS C++ TM spec Example if you have this spec ``` export interface Spec extends TurboModule { +foo: (bar: string) => void; } ``` We must enforce in C++ that the return type is `void` as e.g. ``` void foo(jsi::Runtime& rt, const std::string& bar); ``` Right now you can return any type in C++ such as `std::string` which does not make sense Differential Revision: D79980538
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79980538 |
christophpurrer
force-pushed
the
export-D79980538
branch
from
August 12, 2025 16:53
c40420d to
dc19e14
Compare
Contributor
|
This pull request has been merged in 9f0d24b. |
Collaborator
|
This pull request was successfully merged by @christophpurrer in 9f0d24b When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Fixed] [General] Enforce void return type for void return type in JS C++ TM spec
Example if you have this spec
We must enforce in C++ that the return type is
voidas e.g.Right now you can return any type in C++ such as
std::stringwhich does not make senseDifferential Revision: D79980538