Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions packages/react-native/Libraries/Network/RCTNetworking+Internal.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
/*
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/

#import "RCTNetworking.h"

@protocol RCTNetworkingTextResponseHandler <NSObject>

- (BOOL)canHandleNetworkingTextResponseForRequest:(NSURLRequest *)request;
- (void)handleNetworkingResponseText:(NSString *)responseText request:(NSURLRequest *)request;

@end

@interface RCTNetworking (Internal)

- (void)addTextResponseHandler:(id<RCTNetworkingTextResponseHandler>)handler;

@end
24 changes: 23 additions & 1 deletion packages/react-native/Libraries/Network/RCTNetworking.mm
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,15 @@
#import <React/RCTConvert.h>
#import <React/RCTLog.h>
#import <React/RCTNetworkTask.h>
#import <React/RCTNetworking.h>
#import <React/RCTUtils.h>

#import <React/RCTHTTPRequestHandler.h>
#import <react/featureflags/ReactNativeFeatureFlags.h>

#import "RCTInspectorNetworkReporter.h"
#import "RCTNetworkPlugins.h"
#import "RCTNetworking+Internal.h"
#import "RCTNetworking.h"

typedef RCTURLRequestCancellationBlock (^RCTHTTPQueryResult)(NSError *error, NSDictionary<NSString *, id> *result);

Expand Down Expand Up @@ -153,6 +154,7 @@ @implementation RCTNetworking {
NSArray<id<RCTURLRequestHandler>> * (^_handlersProvider)(RCTModuleRegistry *);
NSMutableArray<id<RCTNetworkingRequestHandler>> *_requestHandlers;
NSMutableArray<id<RCTNetworkingResponseHandler>> *_responseHandlers;
NSMutableArray<id<RCTNetworkingTextResponseHandler>> *_textResponseHandlers;
dispatch_queue_t _requestQueue;
}

Expand Down Expand Up @@ -672,6 +674,18 @@ - (void)sendRequest:(NSURLRequest *)request
if (!(incrementalUpdates && [responseType isEqualToString:@"text"])) {
[strongSelf sendData:data responseType:responseType response:response forTask:task];
}

if ([responseType isEqualToString:@"text"]) {
for (id<RCTNetworkingTextResponseHandler> handler in strongSelf->_textResponseHandlers) {
if ([handler canHandleNetworkingTextResponseForRequest:task.request]) {
NSString *responseString = [RCTNetworking decodeTextData:data
fromResponse:task.response
withCarryData:[NSMutableData new]];
[handler handleNetworkingResponseText:responseString request:task.request];
}
}
}

NSArray *responseJSON =
@[ task.requestID, RCTNullIfNil(error.localizedDescription), error.code == kCFURLErrorTimedOut ? @YES : @NO ];

Expand Down Expand Up @@ -727,6 +741,14 @@ - (void)addResponseHandler:(id<RCTNetworkingResponseHandler>)handler
[_responseHandlers addObject:handler];
}

- (void)addTextResponseHandler:(id<RCTNetworkingTextResponseHandler>)handler
{
if (!_textResponseHandlers) {
_textResponseHandlers = [NSMutableArray new];
}
[_textResponseHandlers addObject:handler];
}

- (void)removeRequestHandler:(id<RCTNetworkingRequestHandler>)handler
{
[_requestHandlers removeObject:handler];
Expand Down
Loading