Skip to content

perf: replace StringBuilder with ValueStringBuilder #2270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TimothyMakkison wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −6
Open

perf: replace StringBuilder with ValueStringBuilder #2270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/Refit/SeparatedCaseFormatter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
// ReactiveUI and Contributors licenses this file to you under the MIT license.
// See the LICENSE file in the project root for full license information.

using System.Text;

namespace Refit;

/// <summary>Converts PascalCase/camelCase identifiers into a lower-case, separator-delimited form (e.g. snake_case or kebab-case).</summary>
Expand All @@ -23,22 +21,22 @@ internal static string Format(string key, char separator)
return key;
}

var builder = new StringBuilder(key.Length + SeparatorCapacityHeadroom);
var builder = new ValueStringBuilder(key.Length + SeparatorCapacityHeadroom);
for (var i = 0; i < key.Length; i++)
{
var current = key[i];
if (char.IsUpper(current))
{
if (i > 0 && NeedsSeparatorBefore(key, i))
{
_ = builder.Append(separator);
builder.Append(separator);
}

_ = builder.Append(char.ToLowerInvariant(current));
builder.Append(char.ToLowerInvariant(current));
}
else
{
_ = builder.Append(current);
builder.Append(current);
}
}

Expand Down
Loading