feat(task): pass scoped user secret names - #319
Conversation
Forward optional secret allowlists and step-local REANA hints from CWL workflows so job submissions preserve workflow defaults, step overrides, and the documented omitted-versus-empty semantics. Closes reanahub/reana#978
b589a4b to
155d2f4
Compare
Forward optional secret allowlists and step-local REANA hints from CWL workflows so job submissions preserve workflow defaults, step overrides, and the documented omitted-versus-empty semantics. Closes reanahub/reana#978
155d2f4 to
f2a39f2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #319 +/- ##
===========================================
+ Coverage 17.47% 29.54% +12.06%
===========================================
Files 10 10
Lines 578 589 +11
===========================================
+ Hits 101 174 +73
+ Misses 477 415 -62
🚀 New features to boost your workflow:
|
Forward optional secret allowlists and step-local REANA hints from CWL workflows so job submissions preserve workflow defaults, step overrides, and the documented omitted-versus-empty semantics. Closes reanahub/reana#978
f2a39f2 to
a9b1c4c
Compare
Forward optional secret allowlists and step-local REANA hints from CWL workflows so job submissions preserve workflow defaults, step overrides, and the documented omitted-versus-empty semantics. Closes reanahub/reana#978
a9b1c4c to
83680b0
Compare
Forward optional secret allowlists and step-local REANA hints from CWL workflows so job submissions preserve workflow defaults, step overrides, and the documented omitted-versus-empty semantics. Closes reanahub/reana#978
83680b0 to
aecf8fc
Compare
tiborsimko
left a comment
There was a problem hiding this comment.
🤖 PR319-01: Modified files omit the current copyright year (NIT)
reana_workflow_engine_cwl/main.py and reana_workflow_engine_cwl/tasks.py are modified in 2026, but their copyright headers currently end in 2025 and 2021 respectively. The repository convention is to include the year of each substantive modification.
Suggested fix — add 2026 to both copyright headers.
| c4p_cpu_cores = self._get_hint("c4p_cpu_cores") | ||
| c4p_memory_limit = self._get_hint("c4p_memory_limit") | ||
| c4p_additional_requirements = self._get_hint("c4p_additional_requirements") | ||
| secret_names = resolve_secret_names( |
There was a problem hiding this comment.
🤖 Cross-component note for PR546-07: align CWL runtime hint resolution with sidecar discovery
The corresponding commons review found that packed-CWL sidecar discovery and ReanaPipelineJob._get_hint() resolve inherited REANA hints differently. Commons currently models step → tool and omits the Workflow node, while the runtime job scans cwltool's inherited workflow → step → tool list from the beginning. A workflow-only secret_names hint therefore scopes the job but leaves the sidecar at None (all secrets), and a step cannot narrow a conflicting workflow-level value.
The runtime resolver in this PR is one half of that contract. Its forward scan also governs compute_backend, kerberos, voms_proxy, rucio, kubernetes_uid, and the other REANA-specific fields, so changing precedence requires coordinated coverage beyond secret_names.
Suggested fix — coordinate this PR with the shared resolver proposed in PR546-07 so runtime job construction and packed-workflow discovery use the same explicitly defined workflow/step/tool precedence. Add packed-CWL regressions for workflow-only and conflicting workflow/step/tool hints, including a shared tool invoked from steps with different local values.
Forward optional secret allowlists and step-local REANA hints from CWL workflows so job submissions preserve workflow defaults, step overrides, and the documented omitted-versus-empty semantics.
Closes reanahub/reana#978