Add pluggable HTTP transport adapter - #963
Closed
sgilrodriguez wants to merge 1 commit into
Closed
Conversation
Introduce an injectable HTTP transport so consumers can supply a custom adapter via Client.new(http_adapter:) instead of being hard-wired to Net::HTTP. Mirrors recurly-client-java#334. Purely additive — the default path is byte-identical and there are no consumer-facing breaking changes. - Add Recurly::HTTP::Adapter base documenting the contract: #call(method, url, headers, body) -> AdapterResponse. - Add Recurly::HTTP::DefaultHttpAdapter wrapping Net::HTTP + the shared class-level ConnectionPool. - Client keeps URL/query building, auth headers, Idempotency-Key, retry, and status->typed-error mapping; the adapter owns only transport and translates transport exceptions into a neutral Errors::TransportError carrying a kind symbol. BILL-1929 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded — see branch
pluggable-http-adapter.