Skip to content

Development Environment using Vagrant#309

Open
pietromenna wants to merge 1 commit into
recursecenter:masterfrom
pietromenna:vagrant-image
Open

Development Environment using Vagrant#309
pietromenna wants to merge 1 commit into
recursecenter:masterfrom
pietromenna:vagrant-image

Conversation

@pietromenna

Copy link
Copy Markdown
Member

This PR contains instructions hat future contributors shall follow to use the Vagrant image recursecenter/community-dev.

It also contains files which are required for proper setup. It has been tested on my environment.

Comment thread .gitignore Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the Vagrantfile be in .gitignore? It's being tracked below.

@pietromenna

Copy link
Copy Markdown
Member Author

@zachallaun the idea is that if a future contributor would like to change the settings for it's own virtual machine (for example, assign more memory), it should not be reported as a change. This is the reason why I added to .gitignore. But I can remove it from .gitignore if you prefer.

@zachallaun

Copy link
Copy Markdown
Member

@pietromenna Gotcha. I think it should be tracked because it's something that might reasonably change. e.g. we update the location of the box to be something other than "recursecenter/community-dev". If people make changes locally, we can just ask that they be omitted from pull requests and such.

@pietromenna

Copy link
Copy Markdown
Member Author

@zachallaun I changed it to continue being a tracked file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants