Improvements to Get-NewSchedule#218
Merged
clr2of8 merged 1 commit intoredcanaryco:masterfrom May 1, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating a new schedule using Invoke-GenerateNewSchedule there exists an edge case when only 1 atomic test is found in the PrivateAtomics folder.
This causes the try-catch block to catch the error and completely swallow it. This is not very transparent and can be improved by writing the error instead.
Furthermore, the proper fix is to wrap the received object from the Loop function in an array before adding them to the AllAtomicTests arraylist object. This fixes the issue.
How to reproduce:
Before (with errors visible):
The mentioned atomic test does not show up in the csv file afterwards.
After: