fix: restore Bazel proto_library rules broken by Bzlmod migration#11
Closed
fcostaoliveira wants to merge 4 commits into
Closed
fix: restore Bazel proto_library rules broken by Bzlmod migration#11fcostaoliveira wants to merge 4 commits into
fcostaoliveira wants to merge 4 commits into
Conversation
Author
|
Superseded by #13 which includes the complete fix: rules_proto, rules_cc, and .bazelversion pinned to Bazel 8.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After a dormant period, CI began failing on both
build-and-testandtest-deb-buildjobs with:Root cause: Under Bzlmod,
proto_libraryandcc_proto_libraryare no longer globally available as native rules. They must be explicitly loaded from the@protobufmodule (protobuf 21+/Bzlmod requirement). Bothsrc/quipper/BUILDandsrc/BUILDwere using these rules without the requiredload(...)statements.Changes
Added the following two load statements at the top of both
src/quipper/BUILDandsrc/BUILD:The
MODULE.bazelalready correctly declaresprotobufas abazel_dep(version31.1) — no changes needed there. Only the BUILD file load statements were missing.Test plan
build-and-testCI job passes (bazel build + test on//src:all //src/quipper:all)test-deb-buildCI job passes (the deb build script calls bazel under the hood)