Skip to content

fix: maybe pyproject does not have poetry data#454

Open
JoanFM wants to merge 1 commit into
masterfrom
fix-parse
Open

fix: maybe pyproject does not have poetry data#454
JoanFM wants to merge 1 commit into
masterfrom
fix-parse

Conversation

@JoanFM

@JoanFM JoanFM commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@hdoordt

hdoordt commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

@JoanFM I opened #455 just now, which supports loading data from standard pyproject.toml files, falling back to the poetry structure. In case of RediSearch, this is preferable, as that project uses uv to manage the python test packages

@JoanFM

JoanFM commented Sep 10, 2025

Copy link
Copy Markdown
Contributor Author

good for me @hdoordt . I actually wonder what this is used for, what is the supposed to override, I just want the CI on RediSearch to pass, and seems like whichever should work

@hdoordt

hdoordt commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

I'm not too well-versed on the internals of this repo, but I'd say it's best to prefer assigning the values if possible.

@JoanFM

JoanFM commented Sep 10, 2025

Copy link
Copy Markdown
Contributor Author

I'm not too well-versed on the internals of this repo, but I'd say it's best to prefer assigning the values if possible.

Me neither, but I actually think that this project should be the RedisBenchAdmin, not sure why it has to take the path from the local running folder. (I believe this is the underlying problem), Not sure what is the purpose of the info extracted and what it intends to print. @filipecosta90 @paulorsousa ?

@JoanFM

JoanFM commented Sep 10, 2025

Copy link
Copy Markdown
Contributor Author

Actually, maybe we need just to remove the pyproject access, not sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants