Enable LTO when build with modules. LTO is set for RediSearch and it is enabled by default.#516
Conversation
❌ Jit Scanner failed - Our team is investigatingJit Scanner failed - Our team has been notified and is working to resolve the issue. Please contact support if you have any questions. 💡 Need to bypass this check? Comment |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2cb9533. Configure here.
2cb9533 to
a6478d5
Compare
❌ Jit Scanner failed - Our team is investigatingJit Scanner failed - Our team has been notified and is working to resolve the issue. Please contact support if you have any questions. 💡 Need to bypass this check? Comment |
a6478d5 to
51c58ce
Compare
❌ Jit Scanner failed - Our team is investigatingJit Scanner failed - Our team has been notified and is working to resolve the issue. Please contact support if you have any questions. 💡 Need to bypass this check? Comment |
51c58ce to
d7894ed
Compare
❌ Jit Scanner failed - Our team is investigatingJit Scanner failed - Our team has been notified and is working to resolve the issue. Please contact support if you have any questions. 💡 Need to bypass this check? Comment |
d7894ed to
52f74cb
Compare
AngelYanev
changed the title
❌ Jit Scanner failed - Our team is investigatingJit Scanner failed - Our team has been notified and is working to resolve the issue. Please contact support if you have any questions. 💡 Need to bypass this check? Comment |
52f74cb to
3d36cb1
Compare
❌ Jit Scanner failed - Our team is investigatingJit Scanner failed - Our team has been notified and is working to resolve the issue. Please contact support if you have any questions. 💡 Need to bypass this check? Comment |
3d36cb1 to
1777347
Compare
❌ Jit Scanner failed - Our team is investigatingJit Scanner failed - Our team has been notified and is working to resolve the issue. Please contact support if you have any questions. 💡 Need to bypass this check? Comment |
AngelYanev
changed the title
❌ Jit Scanner failed - Our team is investigatingJit Scanner failed - Our team has been notified and is working to resolve the issue. Please contact support if you have any questions. 💡 Need to bypass this check? Comment |
74b25e3 to
f4582dd
Compare
❌ Jit Scanner failed - Our team is investigatingJit Scanner failed - Our team has been notified and is working to resolve the issue. Please contact support if you have any questions. 💡 Need to bypass this check? Comment |
f4582dd to
c4b2673
Compare
❌ Jit Scanner failed - Our team is investigatingJit Scanner failed - Our team has been notified and is working to resolve the issue. Please contact support if you have any questions. 💡 Need to bypass this check? Comment |
The earlier LTO change accidentally turned the closing tag of the
custom_build {% if %} block into a plain {% endif %}, dropping the
trailing-whitespace strip and leaving an extra blank line between the
ARG block and the first RUN in the rendered alpine/Dockerfile when
custom_build=false. Put the dash back and re-render so the Dockerfile
matches the template again.
Co-authored-by: Cursor <cursoragent@cursor.com>
❌ Jit Scanner failed - Our team is investigatingJit Scanner failed - Our team has been notified and is working to resolve the issue. Please contact support if you have any questions. 💡 Need to bypass this check? Comment |
2 participants
Note
Medium Risk
Changes the Docker build toolchain and build flags for module-enabled images, which can affect binary size/performance and potentially introduce build/link failures across architectures.
Overview
Enables link-time optimization (LTO) for Redis builds that include modules by exporting
LTO=1whenBUILD_WITH_MODULES=yes(Alpine and Debian, including the.j2templates).Updates module build toolchain dependencies: Alpine now installs
lld21, and Debian switches to installingclang-21/lld-21/llvm-21fromtrixie-backports(with a temporary backports source and updatedPATH) instead of the defaultclangpackage.Reviewed by Cursor Bugbot for commit 3641366. Bugbot is set up for automated code reviews on this repo. Configure here.