Skip to content

Move modules-update to custom_build and gate redis_repo#540

Merged
dariaguy merged 1 commit into
unstablefrom
dariaguy-unstable-custom-fixes
Jul 14, 2026
Merged

Move modules-update to custom_build and gate redis_repo#540
dariaguy merged 1 commit into
unstablefrom
dariaguy-unstable-custom-fixes

Conversation

@dariaguy

@dariaguy dariaguy commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Note

Medium Risk
Changes release Docker build behavior (no modules-update on release images) and CI validation for redis_repo; mistakes could affect official image contents or block legitimate release runs.

Overview
Release automation now rejects run_type=release when redis_repo is not redis/redis, so forked Redis sources are only allowed for custom/unstable/nightly-style runs.

Docker image builds drop the bundled-module modules-update / .prepared shortcut from the checked-in release Alpine and Debian Dockerfiles; those paths go straight from LTO setup to Rust install and make deploy.

The Jinja templates keep modules.yaml pinning, the .prepared skip, and make modules-update only under custom_build, matching how non-release renders are produced while release images rely on the official tarball’s bundled module sources.

Reviewed by Cursor Bugbot for commit 54eecdd. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 54eecdd. Configure here.

Comment thread alpine/Dockerfile.j2
@dariaguy
dariaguy merged commit 24d025d into unstable Jul 14, 2026
24 checks passed
@dariaguy
dariaguy deleted the dariaguy-unstable-custom-fixes branch July 14, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants