Does runtime.FixOpenAI not support lists

[jlewi]

Is there an issue with Fix.OpenAI not working with messages that contain lists of other messages? It doesn't seem like it is recoursing into fields.

Here's an example of OpenAI json that didn't get fixed.

{
  "cells": [
    {
      "call_id": "1",
      "doc_results": [],
      "execution_summary": null,
      "kind": "CELL_KIND_CODE",
      "language_id": "python",
      "metadata": [
        {
          "key": "agent/summary",
          "value": "A simple hello world program."
        }
      ],
      "outputs": [],
      "ref_id": "",
      "role": "CELL_ROLE_USER",
      "text_range": null,
      "value": "print('Hello, World!')"
    }
  ]
}

Here cells is a list of items and FixOpenAI doesn't seem to be recoursing into the list; so metdata doesn't get fixed.

[jlewi]

The following seems to work for me.

func FixOpenAI(descriptor protoreflect.MessageDescriptor, args map[string]any) {
	var rewrite func(msg protoreflect.MessageDescriptor, path []string, obj map[string]any)

	rewrite = func(msg protoreflect.MessageDescriptor, path []string, obj map[string]any) {
		for i := 0; i < msg.Fields().Len(); i++ {
			field := msg.Fields().Get(i)
			name := string(field.Name())
			currentPath := append(path, name)

			if field.IsMap() {
				// Handle map conversion (from array-of-key-value-pairs to object)
				if arr, ok := obj[name].([]any); ok {
					m := make(map[string]any)
					for _, e := range arr {
						if pair, ok := e.(map[string]any); ok {
							k, kOk := pair["key"].(string)
							v, vOk := pair["value"]
							if kOk && vOk {
								m[k] = v
							}
						}
					}
					obj[name] = m
				}
			} else if field.Kind() == protoreflect.MessageKind {
				fullName := string(field.Message().FullName())

				if field.Cardinality() == protoreflect.Repeated {
					if arr, ok := obj[name].([]any); ok {
						for idx, entry := range arr {
							switch fullName {
							case "google.protobuf.Value":
								if str, ok := entry.(string); ok {
									var value any
									if err := json.Unmarshal([]byte(str), &value); err == nil {
										arr[idx] = value
									}
								}
							case "google.protobuf.ListValue":
								if str, ok := entry.(string); ok {
									var listValue []any
									if err := json.Unmarshal([]byte(str), &listValue); err == nil {
										arr[idx] = listValue
									}
								}
							case "google.protobuf.Struct":
								if str, ok := entry.(string); ok {
									var structValue map[string]any
									if err := json.Unmarshal([]byte(str), &structValue); err == nil {
										arr[idx] = structValue
									}
								}
							default:
								if nested, ok := entry.(map[string]any); ok {
									rewrite(field.Message(), currentPath, nested)
								}
							}
						}
						obj[name] = arr
					}
					continue
				}

				// Handle OpenAI string representations of special protobuf types
				switch fullName {
				case "google.protobuf.Value":
					if str, ok := obj[name].(string); ok {
						var value any
						if err := json.Unmarshal([]byte(str), &value); err == nil {
							obj[name] = value
						}
					}
				case "google.protobuf.ListValue":
					if str, ok := obj[name].(string); ok {
						var listValue []any
						if err := json.Unmarshal([]byte(str), &listValue); err == nil {
							obj[name] = listValue
						}
					}
				case "google.protobuf.Struct":
					if str, ok := obj[name].(string); ok {
						var structValue map[string]any
						if err := json.Unmarshal([]byte(str), &structValue); err == nil {
							obj[name] = structValue
						}
					}
				default:
					// Recursively process nested messages
					if nested, ok := obj[name].(map[string]any); ok {
						rewrite(field.Message(), currentPath, nested)
					}
				}
			}
		}
	}

	rewrite(descriptor, nil, args)
}

[birdayz]

Sorry for the late response on this.

You were right -- FixOpenAI wasn't handling well-known types (Value, ListValue, Struct) inside repeated fields. The repeated field handler only recursed into nested messages but skipped the string-to-JSON conversion for WKTs entirely.

Fixed in #38. Added a test that reproduces your exact scenario.

Thanks for the detailed report (and the proposed fix in your comment -- it was spot on).