Add scoped find navigation to file previews - #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Long code and Markdown previews had no in-file navigation, while the application already owned Cmd/Ctrl+F for other focused surfaces.
Implementation
Architectural choices
Tests performed
NODE_OPTIONS=--max-old-space-size=4096 bun run testinapps/web: 369 files / 4,287 tests passedbun run fmt:check: passedbun run lint: 0 errors (existing workspace warnings remain)bun run typecheck: 7/7 packages passedNODE_OPTIONS=--max-old-space-size=4096 bun run buildinapps/web: passedManual / browser validation
Known limitations
Closes #153