feat: configurable default folders for media and per-type new notes

[yusoufu]

Summary

• Adds default_image_folder and default_video_folder global settings to route pasted/dropped media into a user-chosen vault folder (falls back to attachments/ when unset)
• Generalises image.rs into a shared media pipeline that also handles videos via new save_video / copy_video_to_vault Tauri commands
• Adds _default_folder field on type-note frontmatter — when set, new notes of that type are created in the named subfolder; existing notes are not moved
• Adds a shared shadcn FolderPicker component used by Settings ("Media" section) and the per-type Customize popover
• Path validation (normalize_vault_relative_folder) in a single Rust helper rejects absolute paths, .. traversal, and empty input across settings, frontmatter, and media writes
• Fixes a flaky Rust search test that failed when the workspace lived under a dotfile-prefixed parent directory (e.g. .claude/worktrees/…) by using the OS tempdir for the fixture

See ADR-0085 for design decisions.

Test plan

• Paste/drop an image with default_image_folder set → lands in correct subfolder
• Paste/drop an image with no setting → falls back to attachments/
• Create a note whose type has _default_folder set → note created in that folder
• Create a note whose type has no _default_folder → note created at vault root
• Set an absolute path or ../escape in FolderPicker → validation rejects it
• cargo test passes (including the fixed search test)
• pnpm test passes including FolderPicker.test.tsx, useImageDrop.test.ts, useNoteCreation.test.ts

🤖 Generated with Claude Code

[codacy-production]

Not up to standards ⛔

🔴 Issues 9 high · 23 medium

Alerts:
⚠ 32 issues (≤ 0 issues of at least minor severity)

Results:
32 new issues

Category	Results
UnusedCode	7 medium
BestPractice	11 medium
ErrorProne	3 medium 7 high
Security	2 high
Complexity	2 medium

View in Codacy

🟢 Metrics 172 complexity · 22 duplication

Metric	Results
Complexity	172
Duplication	22

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

_{TIP This summary will be updated as you push new changes.}

[codacy-production]

Pull Request Overview

Although the project remains 'Up to Standards' according to Codacy, this PR introduces 25 new static analysis issues across four files, with src/components/FolderPicker.tsx accounting for 16 of them. There is a lack of evidence regarding the verification of the media pipeline and path validation logic (e.g., rejecting directory traversal). These areas represent high-risk logic that should be covered by automated tests before merging. Furthermore, the specialized agents reported an inability to verify the code changes, suggesting that a manual verification of the implementation logic for 'default_folder' and media fallback is required.

About this PR

• The implementation of the path validation logic (preventing absolute paths and directory traversal) and the media storage pipeline could not be verified by automated agents. Please ensure these have been manually reviewed or that the missing test scenarios have been addressed.
• There are 16 new issues in src/components/FolderPicker.tsx and 5 new issues in src/components/ImageLightbox.tsx. These should be resolved to maintain code health, especially in the shared FolderPicker component.

Test suggestions

• Verify image paste lands in configured subfolder
• Verify media fallback to 'attachments/' when settings are empty
• Verify note creation respects '_default_folder' frontmatter
• Verify path validation rejects '../' traversal and absolute paths
• Verify FolderPicker component rendering and selection logic
• Verify the fix for the flaky Rust search test in dotfile-prefixed paths

Prompt proposal for missing tests

Consider implementing these tests if applicable:
1. Verify image paste lands in configured subfolder
2. Verify media fallback to 'attachments/' when settings are empty
3. Verify note creation respects '_default_folder' frontmatter
4. Verify path validation rejects '../' traversal and absolute paths
5. Verify FolderPicker component rendering and selection logic
6. Verify the fix for the flaky Rust search test in dotfile-prefixed paths

_{TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback}

[codacy-production]

Pull Request Overview

This PR introduces configurable media folders and per-type note storage, but contains critical performance and accessibility issues that should be addressed before merging.

Codacy analysis indicates the PR is not up to standards, with 28 new issues. Most notably, the useImageDrop hook uses a manual string concatenation loop for base64 conversion which is highly inefficient for the large video files this PR now supports; this could lead to memory exhaustion or main-thread blocking.

From an architectural standpoint, there is a discrepancy between the ADR/documentation—which states absolute paths will be rejected—and the implementation, which instead normalizes them by stripping slashes. Furthermore, several accessibility gaps were identified in the new FolderPicker component, including non-compliant ARIA listbox behavior and disconnected form labels. Finally, the Image Lightbox feature was added without being documented in the PR description.

About this PR

• Discrepancy in path handling: The implementation normalizes paths (stripping slashes) whereas the ADR/documentation suggests they should be rejected. Please align the documentation with the code or update the validation to reject absolute paths as planned.
• The PR introduces a new Image Lightbox feature and double-click handler that are not mentioned in the PR description or summary. Please update the description to reflect these changes.

2 comments outside of the diff

src/components/sidebar/SidebarSections.tsx

_{line 273 🟡 MEDIUM RISK}
Suggestion: The button element should have an explicit type="button" attribute to prevent it from defaulting to a submit button.

src/hooks/useNoteCreation.ts

_{line 62 ⚪ LOW RISK}
Suggestion: The callback passed to forEach implicitly returns a value because Set.add returns the updated set. Use curly braces to clarify this is a side-effect-only operation.

Test suggestions

• Validate Rust folder normalization logic (rejection of traversal segments and redundancy checks)
• Verify media save pipeline correctly resolves custom folders and handles fallback to 'attachments'
• Verify TypeScript folder picker validation and clear/escape interactions
• Verify note creation logic correctly computes absolute paths using type-specific folders
• Verify image lightbox double-click detection and size filtering for tracking pixels

_{TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback}

[codacy-production]

_{🔴 HIGH RISK}

The <label> element is not programmatically associated with any input control. Update FolderPicker to accept an id prop and use it in the label's htmlFor attribute to ensure screen reader compatibility.

See Issue in Codacy

[codacy-production]

_{🔴 HIGH RISK}

The <ul> element is assigned role="listbox" but lacks the necessary keyboard interaction logic (e.g., arrow key navigation) to be fully accessible. Implement keyboard navigation or use a semantically neutral container if strict ARIA compliance isn't intended.

See Issue in Codacy

[codacy-production]

_{🔴 HIGH RISK}

The manual character-by-character string concatenation loop is inefficient for large media files like videos. Use FileReader.readAsDataURL and strip the metadata prefix to perform the base64 conversion natively and avoid blocking the main thread.

[codacy-production]

_{⚪ LOW RISK}

Nitpick: This condition is redundant and unreachable because the trim_matches('/') call on line 94 has already removed all leading and trailing slashes from the string.