fix: persist ui language across browser reloads#834
Open
rezawr wants to merge 27 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #828 — UI language choice was not being persisted across browser reloads.
Changes
src/mock-tauri/mock-handlers.ts— hydrate the mockSettingsfromlocalStorageon module load, and write through tolocalStorageon everysave_settingscall.try/catchguards so a private-mode / quota failure degrades to in-memory only instead of throwing.src/components/SettingsPanel.tsx+SettingsFooter.tsx—handleSaveis now async: it awaits theonSavepromise, then closes the panel. The Close and Save buttons are disabled while a save is in flight, so the panel can't be dismissed mid-write.src/mock-tauri/mock-handlers.coverage.test.ts— new regression test: writesui_language: 'it-IT', reloads the handlers module, asserts the language is still'it-IT'.src/mock-tauri/mock-handlers.more.test.ts—localStorage.clear()inbeforeEachso the new persistence doesn't leak between tests.src/components/SettingsPanel.test.tsx— new test pinning the async-save contract:onCloseis not called until the save promise resolves, and the Save button is disabled in the meantime.