WIP: Add Reflex.Dom.Event to expose addEventListener options#402
Open
WIP: Add Reflex.Dom.Event to expose addEventListener options#402
Conversation
3noch
force-pushed
the
eac@expose-addEventListener-options
branch
from
d1f7535 to
1dd4cf8
Compare
Member
Author
|
These changes could all go in |
3noch
commented
Jul 16, 2020
| -- for differences. | ||
| normalizedDefaultEventListenerOptions :: EventName t e -> EventListenerOptions | ||
| normalizedDefaultEventListenerOptions e = case eventNameString e of | ||
| name | name == "touchstart" || name == "touchmove" -> defaultEventListenerOptions { _eventListenerOptions_passive = True } |
Member
Author
There was a problem hiding this comment.
Downside to this approach is that it's a perf hit to every usage of on
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some events like
touchstartandtouchmovebehave differently (by default) on different browsers. However, changing the default settings inaddEventHandleris not at all straightforward. This PR attempts to solve two problems:addEventHandler.onfor DOM events that always normalizes the behavior between browers so there is no discrepancy.The changes are added in a new
Reflex.Dom.Eventmodule. Bikeshed away. Many things in Immediate.hs should probably be moved to this module as well.