Fix incorrect use of unsafeBuildIncremental in runQueryT#530
Open
parenthetical wants to merge 1 commit intoreflex-frp:developfrom
Open
Fix incorrect use of unsafeBuildIncremental in runQueryT#530parenthetical wants to merge 1 commit intoreflex-frp:developfrom
parenthetical wants to merge 1 commit intoreflex-frp:developfrom
Conversation
179ae0f to
ace4dde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small issue I discovered while writing alternative implementations:
runQueryTviolates theunsafeBuildIncrementalcontract. The behavior being sampled only reflects the initial value, not the value at any time:This just happened to work because the unsafe-built incremental tends to be forced immediately.