Stop duplicate entries for idmap being created#62
Open
simpz wants to merge 1 commit intorehanone:masterfrom
Open
Stop duplicate entries for idmap being created#62simpz wants to merge 1 commit intorehanone:masterfrom
simpz wants to merge 1 commit intorehanone:masterfrom
Conversation
The current code assumes spaces around the idmap colon parameter and leaves duplicate entries if in the original file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code assumes spaces around the idmap colon parameter and leaves duplicate entries if in the original file there were identical idmap parameters (but differing only in their spacing in the parameters).
Incidentally this is true about any parameter used with this module, just a lot harder to fix as this seems to need work in augeas.