Skip to content

feat: Add Audio tab to keyboard.json Form Editor#918

Merged
yoichiro merged 1 commit intomainfrom
feature/workbench-keyboard-json-audio
Mar 26, 2026
Merged

feat: Add Audio tab to keyboard.json Form Editor#918
yoichiro merged 1 commit intomainfrom
feature/workbench-keyboard-json-audio

Conversation

@yoichiro
Copy link
Copy Markdown
Collaborator

Summary

  • Add a dedicated Audio tab to the keyboard.json Form Editor with support for:
    • audio.pins — audio output pins (comma-separated text input)
    • audio.driver — driver selection (pwm_hardware, pwm_software, dac_basic, dac_additive)
    • audio.voices — enable multiple audio voices (with description)
    • audio.macro_beep — play beep on macro execution (with description)
  • Rename Input tab to Encoder for clarity
  • Reorder tabs: Audio (5) comes before Encoder (6)
  • Add Japanese translations for all new labels and descriptions

Test plan

  • Open keyboard.json → Form Editor → verify Audio tab appears between Lighting and Encoder
  • Set audio pins to "C6" → switch to Code Editor → verify "audio": { "pins": ["C6"] } in JSON
  • Select driver "pwm_hardware" → verify it appears in JSON
  • Toggle Voices on → verify "voices": true in JSON
  • Toggle Macro Beep on → verify "macro_beep": true in JSON
  • Verify Voices and Macro Beep switches show description text
  • Verify Encoder tab (formerly Input) still works correctly
  • Verify Japanese locale displays correctly for Audio tab and descriptions

🤖 Generated with Claude Code

…oices, and macro beep settings

Add a dedicated Audio tab to the keyboard.json Form Editor supporting
audio.pins, audio.driver (pwm_hardware/pwm_software/dac_basic/dac_additive),
audio.voices, and audio.macro_beep properties. Rename Input tab to Encoder
and reorder tabs so Audio comes before Encoder. Add helper text descriptions
for Voices and Macro Beep switches.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@yoichiro yoichiro merged commit b61f6f8 into main Mar 26, 2026
1 check passed
@yoichiro yoichiro deleted the feature/workbench-keyboard-json-audio branch March 26, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant