fix: Trim stale keycodes when keyboard.json layout shrinks#922
Merged
Conversation
When a key is removed from keyboard.json, subsequent Visual Editor edits previously left the deleted keycodes in keymap.c because localKeymap still held the original keycodeNames array. Trim each layer's keycodeNames to the current layout key count inside applyKeymapUpdate so every edit path (key change, layer add/delete) keeps keymap.c in sync with the layout. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
keyboard.json, subsequent Visual Editor edits previously left the deleted keycodes behind inkeymap.cbecauselocalKeymapstill held the originalkeycodeNamesarray.applyKeymapUpdatenow trims each layer'skeycodeNamesto the current layout key count, so every edit path (key change, layer add/delete) keepskeymap.cin sync with the layout.Test plan
npm run type-checkpassesnpm run lint(no new errors from this change)npm test -- --run src/services/workbench src/components/workbench(173 tests pass)🤖 Generated with Claude Code